Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C Compose
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Alloy Magnetic
  • Compose
  • Merge requests
  • !19

Merged
Created Jul 03, 2019 by Jordan White@jowhiteDeveloper

Change EntityBase Type Hint to ContentEntityBase

  • Overview 2
  • Commits 2
  • Changes 2

This changes instances of the EntityBase typehinting of the addExistingRow method in the ComposeWidgetInterface.php and EntityComposeWidget.php files to ContentEntityBase. I believe that this was probably the intent of this typehint. ContentEntityBase should still support all of the entity types I believe we intend to support with this widget.

Typehinting EntityBase results in an error since the Assembly class, at least in the testing case I used, was being passed.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: change-entitybase-type-hinting