Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • C Compose
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 19
    • Issues 19
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Alloy Magnetic
  • Compose
  • Merge requests
  • !35

Open
Created Jan 14, 2021 by Stacy Mosier@smosierDeveloper
  • Report abuse
Report abuse

Add field_group support to uninstall

  • Overview 0
  • Commits 2
  • Changes 1

When we uninstall field_layout and compose, the config settings for

third_party_settings:
  field_group:
    group_group_name:
      region: fields

remain assigned to the 'fields' region. When we view the Form mode for the entity, these groups end up in the 'hidden' region, and there are PHP errors from field_ui (because the child fields reference a parent that doesn't exist?).

This change moves any field_groups that are not already hidden into the default content region.

Since this uninstall hook already provides me the resulting yml that I want, I only need to commit my yml to move forward.
But if you want to improve this or need it for later, I figured an MR was the best way to collaborate with you on this issue.

I could not determine which part of the uninstall / entity_display save process was making the non-group fields reassign to the correct default region; If there is a more "core" way of doing this, I'd love to know :)

Edited Jan 14, 2021 by Stacy Mosier
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: uninstall-move-field-groups